Force button does not work when using the new categories in farmreport (Bug #215)
Force button does not work when using the new categories farmreport. The buttons are shown if the BuildServer has new enough version but nothing happens when you press the buttons.
Possible the start/stop/abort button have the same problem.
Configuration for the problem to occur (in Dashboard.config):
<remoteServices> <servers> <!-- Update this list to include all the servers you want to connect to. NB - each server name must be unique --> <server name="MyBuildServer1" url="tcp://MyBuildServer1:21234/CruiseManager.rem" allowForceBuild="true" allowStartStopBuild="true" /> <server name="MyBuildServer2" url="tcp://MyBuildServer2:21234/CruiseManager.rem" allowForceBuild="true" allowStartStopBuild="true" /> </servers> </remoteServices> <plugins> <farmPlugins> <farmReportFarmPlugin categories="true" refreshInterval="30" successBar="Bottom" /> <cctrayDownloadPlugin /> <administrationPlugin password="XYZ123"></administrationPlugin> </farmPlugins>Aditional feature:
- Enable sorting within each category through header click. It is acceptable that this sorting sorts all categories at once.
The problem seems to be that when you use categories="true" the dashboard uses a completely different "Farm Report Farm" plugin and template from when it is set to false.
The quick fix is to turn categories off (categories="false") as the standard farm view works fine.
I did a fix for myself for which I have attached the patch, but I haven't particularly tested it beyond checking it fixes the issue for myself.
- File 215CategorizationFix.diff added
Paul: I only took a quick look at the code and it looks ok to me. I bet a diff with the code of the "normal" webpage shows if your code is similar. Best would be some kind of base class that both uses so all features are exactly the same.
Only admins can change the header of the issue otherwise I would change it to 1.8.4 and vote to apply your patch.