p4 sourcecontrol block's workingDirectory is ignored (Bug #249)


Added by Daniel Szabo almost 5 years ago. Updated over 4 years ago.


Status:Closed Start date:01/10/2013
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:Source Control Spent time: -
Target version:1.8.4 Estimated time:1.00 hour
Affected version:1.6

Description

I wanted to use the <workingDirectory>d:\x\y\z</workingDirectory> parameter for the p4 sourcecontrol block, but it seems it is completely ignored. (I wanted ccnet to create the p4.exe process in the directory I specified in order to use my .p4config file)

See the CreateProcessInfo method of P4ConfigProcessInfoCreator class. If I add the line between the comments it works.

public ProcessInfo CreateProcessInfo(P4 p4, string extraArguments){
ProcessInfo processInfo = new ProcessInfo(p4.Executable, BuildCommonArguments(p4) + extraArguments);
processInfo.TimeOut = 0; // Don't time out - this should be configurable
// dszabo - this is really missing
processInfo.WorkingDirectory = p4.WorkingDirectory;
// dszabo
return processInfo;
}


History

Updated by Ruben Willems over 4 years ago

  • Status changed from New to Closed

Also available in: Atom PDF