ArgumentNullException when using MultiSourceControl with svn (Bug #304)

Added by Daniel Rose almost 5 years ago. Updated almost 5 years ago.

Status:Closed Start date:09/03/2013
Priority:Normal Due date:
Assignee:Ruben Willems % Done:


Category:Source Control Spent time: -
Target version:1.8.5
Affected version:1.8.4


The bug fix of #196 causes a new bug when using MultiSourceControl in combination with Subversion:

System.ArgumentNullException: Der Wert darf nicht NULL sein.
Parametername: s
   bei System.IO.StringReader..ctor(String s)
   bei ThoughtWorks.CruiseControl.Remote.XmlConversionUtil.CanConvertXmlToObject(Type messageType, String message)
   bei ThoughtWorks.CruiseControl.Core.Sourcecontrol.MultiSourceControl.GetModifications(IIntegrationResult from, IIntegrationResult to)
   bei ThoughtWorks.CruiseControl.Core.Sourcecontrol.QuietPeriod.GetModificationsWithLogging(ISourceControl sc, IIntegrationResult from, IIntegrationResult to)
   bei ThoughtWorks.CruiseControl.Core.Sourcecontrol.QuietPeriod.GetModifications(ISourceControl sourceControl, IIntegrationResult lastBuild, IIntegrationResult thisBuild)
   bei ThoughtWorks.CruiseControl.Core.IntegrationRunner.GetModifications(IIntegrationResult from, IIntegrationResult to)
   bei ThoughtWorks.CruiseControl.Core.IntegrationRunner.Integrate(IntegrationRequest request)

The reason is that the Subversion source control block, in svn.cs - GetModifications(), creates SourceControlData. The name is "SVN:LastRevision:" + repositoryUrl. The value is the revision number (if there are modifications) or null. However, the changes in XmlConversionUtil assume that the value is never null.


Updated by Daniel Rose almost 5 years ago

I fixed this by simply returning false when a null value is passed to CanConvertXmlToObject(). See the pull request

Updated by Ruben Willems almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Ruben Willems
  • Target version set to 1.8.5

Updated by Ruben Willems almost 5 years ago

  • Status changed from In Progress to Resolved

Updated by Ruben Willems almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF